Skip to content

[TRY] Extend CI by adding some more build_std runs #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[TRY] Extend CI by adding some more build_std runs #1785

wants to merge 3 commits into from
+95 −29

Conversation

sayantn
Copy link
Contributor

@sayantn sayantn commented Apr 21, 2025 •
edited
Loading

This PR adds CI support for Tier 3 targets which don't have a prebuilt toolchain available, notably riscv32gc-unknown-linux-gnu

Support for adding aarch64_be-unknown-linux-gnu runs is delegated to #1786

Adds support for running the aarch64-pc-windows-msvc runners in the new windows-11-arm runners

@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2025

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@sayantn sayantn force-pushed the extend-ci branch 5 times, most recently from 13599cb to a4a35e0 Compare April 21, 2025 09:16
@sayantn sayantn mentioned this pull request Apr 22, 2025
Merged
@Jamesbarford Jamesbarford mentioned this pull request Apr 22, 2025
Open
@sayantn sayantn changed the title [TRY] Extend CI by adding aarch64_be and riscv32 runs [TRY] Extend CI by adding some more build_std runs Apr 23, 2025
@sayantn sayantn force-pushed the extend-ci branch 9 times, most recently from d06790b to ba14a3e Compare April 25, 2025 20:09
@adamgemmell adamgemmell mentioned this pull request Apr 28, 2025
Open
@sayantn sayantn force-pushed the extend-ci branch 2 times, most recently from 731456f to df9da2c Compare April 28, 2025 13:39
@sayantn
Copy link
Contributor Author

sayantn commented Apr 28, 2025

There seems to be a few CI failures in aarch64-pc-windows-msvc (only in release mode)

disassembly for stdarch_test_shim_test_arm_mte_create_random_tag_irg: 
	 0: 9ac11000
	 1: ret

thread 'core_arch::aarch64::mte::test::assert_test_arm_mte_create_random_tag_irg' panicked at crates\stdarch-test\src\lib.rs:185:9:
failed to find instruction `irg` in the disassembly
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- core_arch::aarch64::mte::test::assert_test_arm_mte_ptrdiff_subp stdout ----
disassembly for stdarch_test_shim_test_arm_mte_ptrdiff_subp: 
	 0: 9ac10000
	 1: ret

thread 'core_arch::aarch64::mte::test::assert_test_arm_mte_ptrdiff_subp' panicked at crates\stdarch-test\src\lib.rs:185:9:
failed to find instruction `subp` in the disassembly

---- core_arch::aarch64::mte::test::assert_test_arm_mte_set_tag_stg stdout ----
disassembly for stdarch_test_shim_test_arm_mte_set_tag_stg: 
	 0: d9200800
	 1: ret

thread 'core_arch::aarch64::mte::test::assert_test_arm_mte_set_tag_stg' panicked at crates\stdarch-test\src\lib.rs:185:9:
failed to find instruction `stg` in the disassembly

---- core_arch::aarch64::neon::assert_vget_high_f64_dup stdout ----
disassembly for stdarch_test_shim_vget_high_f64_dup: 
	 0: umov x8 v0.d[1]
	 1: fmov d0 x8
	 2: ret

thread 'core_arch::aarch64::neon::assert_vget_high_f64_dup' panicked at crates\stdarch-test\src\lib.rs:185:9:
failed to find instruction `dup` in the disassembly

cc @Amanieu. The vget_high_f64 seems to be a generic move inconsistency again, but idk what is going on with the MTE ones (the tests all pass in dev mode)

@Amanieu
Copy link
Member

Amanieu commented May 1, 2025

vget_high_f64 is just a move, it should have its instruction test removed.

For the MTE instructions I think the issue is that the MSVC disassembler (dumpbin) doesn't support those instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayantn @rustbot @Amanieu